-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: optimize the use of GroupQuotaManager's hierarchyLock #681
koord-scheduler: optimize the use of GroupQuotaManager's hierarchyLock #681
Conversation
Codecov ReportBase: 68.92% // Head: 68.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 68.92% 68.66% -0.26%
==========================================
Files 205 205
Lines 23329 23341 +12
==========================================
- Hits 16079 16028 -51
- Misses 6141 6208 +67
+ Partials 1109 1105 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9f0c5d5
to
a1a8183
Compare
282957e
to
eb5e469
Compare
6fbdc8d
to
ebcf72d
Compare
60234cc
to
5399f23
Compare
5399f23
to
8c059ac
Compare
8c059ac
to
dd6cb1f
Compare
04e264c
to
f8813df
Compare
f8813df
to
ff56320
Compare
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
0b53d0c
to
da6e095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
Make groupQuotaManager's hierarchyUpdateLock not exposed, then modify the functions call groupQuotaManager's corresponding functions.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test