-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: make Coscheduling/ElasticQuota/DeviceShare plugins more flexible #704
koord-scheduler: make Coscheduling/ElasticQuota/DeviceShare plugins more flexible #704
Conversation
825b30a
to
009ea9a
Compare
Codecov ReportBase: 68.92% // Head: 68.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
- Coverage 68.92% 68.89% -0.03%
==========================================
Files 205 205
Lines 23329 23330 +1
==========================================
- Hits 16079 16073 -6
- Misses 6141 6149 +8
+ Partials 1109 1108 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
009ea9a
to
ed8e1bb
Compare
d472e49
to
fcf9d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fcf9d9a
to
35845dd
Compare
…ore flexible Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
35845dd
to
e690f9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
1、make some functions from func xxx() to var xxx = func()
2、deviceResourceNames -> DeviceResourceNames
3、nvidiaGpuExist -> NvidiaGpuExist and etc.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test