Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Better CI pipeline #74

Merged
merged 2 commits into from
Apr 15, 2022
Merged

🌱 Better CI pipeline #74

merged 2 commits into from
Apr 15, 2022

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented Apr 14, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #75

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@hormes
Copy link
Member

hormes commented Apr 15, 2022

/lgtm
/approve

@jasonliu747
Copy link
Member Author

jasonliu747 commented Apr 15, 2022

well, it's wayyyy better now. cc @hormes
image

@hormes
Copy link
Member

hormes commented Apr 15, 2022

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Apr 15, 2022
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 15, 2022
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@067458b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f68b811 differs from pull request most recent head c7e4972. Consider uploading reports for the commit c7e4972 to get more accurate results

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage        ?   42.90%           
=======================================
  Files           ?       65           
  Lines           ?     5183           
  Branches        ?        0           
=======================================
  Hits            ?     2224           
  Misses          ?     2749           
  Partials        ?      210           
Flag Coverage Δ
unittests 42.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067458b...c7e4972. Read the comment docs.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747 jasonliu747 marked this pull request as ready for review April 15, 2022 04:57
@koordinator-bot koordinator-bot bot requested a review from hormes April 15, 2022 04:57
@hormes hormes merged commit 09acf38 into koordinator-sh:main Apr 15, 2022
@jasonliu747 jasonliu747 deleted the ci branch April 15, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI pipeline is not efficient and w/o codecov
3 participants