-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: only allow the leader to initialize controllers #764
koord-scheduler: only allow the leader to initialize controllers #764
Conversation
37ea4fe
to
9dcf093
Compare
Codecov ReportBase: 68.40% // Head: 68.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 68.40% 68.20% -0.20%
==========================================
Files 209 210 +1
Lines 24053 24120 +67
==========================================
- Hits 16453 16452 -1
- Misses 6455 6527 +72
+ Partials 1145 1141 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9dcf093
to
352a7c8
Compare
352a7c8
to
84e1e7e
Compare
The kubernetes scheduling framework supports the configuration of the same plugin into multiple profiles. For example, |
There is another solution, instead of passing the status of the leader around and just to control whether the controller is started, it is better to define a new interface, and the FrameworkExtender perceives whether the Plugin provides a Controller, and saves these Controller instances, and then in the It is enough to start these Controllers when scheduler.Scheduler is started. In this way, the implementation is clearer, has good scalability, and is minimally intrusive to existing code, and can maintain only one Controller globally. |
f462f83
to
a7c3d2a
Compare
753d82a
to
c27a314
Compare
c27a314
to
afe0561
Compare
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
afe0561
to
c83db49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #762
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test