Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set cgroup value for BE pod #78

Merged
merged 3 commits into from
Apr 18, 2022
Merged

✨ Set cgroup value for BE pod #78

merged 3 commits into from
Apr 18, 2022

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #53

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #78 (344ed21) into main (9b0c938) will decrease coverage by 0.58%.
The diff coverage is 35.33%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   41.25%   40.66%   -0.59%     
==========================================
  Files          65       66       +1     
  Lines        5183     5144      -39     
==========================================
- Hits         2138     2092      -46     
+ Misses       2840     2804      -36     
- Partials      205      248      +43     
Flag Coverage Δ
unittests 40.66% <35.33%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 9.72% <0.00%> (ø)
pkg/koordlet/pleg/pleg.go 69.28% <ø> (ø)
pkg/koordlet/resmanager/cpu_suppress.go 0.00% <0.00%> (ø)
pkg/koordlet/resmanager/resmanager.go 0.00% <0.00%> (ø)
pkg/koordlet/statesinformer/kubelet_stub.go 0.00% <ø> (ø)
pkg/koordlet/statesinformer/states_informer.go 8.21% <ø> (ø)
pkg/util/config.go 0.00% <0.00%> (ø)
pkg/util/cpuinfo.go 68.46% <ø> (ø)
pkg/util/feature.go 0.00% <ø> (ø)
pkg/util/http.go 0.00% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0c938...344ed21. Read the comment docs.

@jasonliu747 jasonliu747 marked this pull request as ready for review April 16, 2022 11:08
@koordinator-bot koordinator-bot bot requested a review from FillZpp April 16, 2022 11:09
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Apr 18, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b84b987 into koordinator-sh:main Apr 18, 2022
@jasonliu747 jasonliu747 deleted the issue-53 branch April 18, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] set cgroup value by batch-request/limit for BE pod
4 participants