Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the method of custom querying quota name #821

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

xulinfei1996
Copy link
Contributor

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 67.91% // Head: 67.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cf67e1c) compared to base (d3b92f1).
Patch coverage: 65.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   67.91%   67.90%   -0.01%     
==========================================
  Files         216      216              
  Lines       24376    24386      +10     
==========================================
+ Hits        16555    16560       +5     
- Misses       6671     6677       +6     
+ Partials     1150     1149       -1     
Flag Coverage Δ
unittests 67.90% <65.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/scheduler/plugins/elasticquota/plugin_helper.go 79.20% <63.63%> (+0.63%) ⬆️
pkg/webhook/elasticquota/pod_check.go 86.84% <66.66%> (+1.12%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/descheduler/evictions/evictions.go 91.08% <0.00%> (+0.18%) ⬆️
...eduler/plugins/coscheduling/controller/podgroup.go 74.14% <0.00%> (+1.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title make ElasticQuota more flexible Support the method of custom querying quota name Nov 18, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Nov 23, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b401d54 into koordinator-sh:main Nov 23, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants