Improve readme #88
Improve readme #88
Conversation
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 40.81% 40.81%
=======================================
Files 66 66
Lines 5145 5145
=======================================
Hits 2100 2100
Misses 2795 2795
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
/lgtm |
README.md
Outdated
| @@ -57,7 +57,7 @@ our [Community Membership](docs/community/community-membership.md) page. | |||
| You can reach the maintainers of this project at: | |||
|
|
|||
| - [Slack](https://join.slack.com/t/koordinator-sh/shared_invite/zt-1756qoub4-Cn4~esfdlfAPsD7cwO2NzA) | |||
| - DingTalk: Search Group ID `33383887` or scan the following QR Code | |||
| - DingTalk(Chinese): Search Group ID `33383887` or scan the following QR Code | |||
|
|
|||
| <div> | |||
| <img src="https://github.com/koordinator-sh/koordinator/raw/main/docs/images/dingtalk.jpg" width="300" alt="Dingtalk QRCode"> | |||
There was a problem hiding this comment.
You need to change the url of qrcode to dingtalk.png.
p.s. 我个人认为原本包含群组名称的图片会比较好看，可以用小工具把人数给 P 掉～
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews