Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add expire cache #93

Merged
merged 1 commit into from
Apr 26, 2022
Merged

🌱 add expire cache #93

merged 1 commit into from
Apr 26, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #93 (d5a22bc) into main (1dbd7c8) will increase coverage by 3.44%.
The diff coverage is 56.81%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   40.81%   44.26%   +3.44%     
==========================================
  Files          66       72       +6     
  Lines        5145     5946     +801     
==========================================
+ Hits         2100     2632     +532     
- Misses       2795     3019     +224     
- Partials      250      295      +45     
Flag Coverage Δ
unittests 44.26% <56.81%> (+3.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/memory_evict.go 0.00% <0.00%> (ø)
pkg/koordlet/resmanager/resmanager.go 2.72% <0.00%> (+2.72%) ⬆️
pkg/cache/expiration_cache.go 75.75% <75.75%> (ø)
pkg/util/system/common.go 52.38% <0.00%> (-43.28%) ⬇️
pkg/util/utils.go 76.00% <0.00%> (-11.70%) ⬇️
pkg/util/system/cgroup.go 70.00% <0.00%> (-9.55%) ⬇️
pkg/util/container.go 26.81% <0.00%> (-2.56%) ⬇️
...kg/koordlet/resmanager/resource_update_executor.go 43.05% <0.00%> (ø)
pkg/tools/cache/expiration_cache.go 70.90% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbd7c8...d5a22bc. Read the comment docs.

@hormes
Copy link
Member

hormes commented Apr 26, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8ad6cf9 into koordinator-sh:main Apr 26, 2022
@jasonliu747 jasonliu747 deleted the cache branch April 29, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants