Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ support LLC & MBA isolation #94

Merged
merged 1 commit into from
Apr 29, 2022
Merged

✨ support LLC & MBA isolation #94

merged 1 commit into from
Apr 29, 2022

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #56

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #94 (b2745dd) into main (1a83fb3) will increase coverage by 2.50%.
The diff coverage is 73.22%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   47.31%   49.82%   +2.50%     
==========================================
  Files          75       77       +2     
  Lines        6668     7248     +580     
==========================================
+ Hits         3155     3611     +456     
- Misses       3198     3309     +111     
- Partials      315      328      +13     
Flag Coverage Δ
unittests 49.82% <73.22%> (+2.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/resmanager.go 2.75% <0.00%> (ø)
pkg/util/config.go 0.00% <0.00%> (ø)
pkg/util/system/cgroup.go 59.82% <0.00%> (-10.18%) ⬇️
pkg/util/system/cgroup_resource.go 0.00% <ø> (ø)
pkg/util/system/resctrl.go 42.69% <42.69%> (ø)
pkg/util/system/resctrl_linux.go 74.28% <74.28%> (ø)
pkg/tools/cache/expiration_cache.go 75.75% <84.37%> (+4.84%) ⬆️
pkg/koordlet/resmanager/resctrl_reconcile.go 88.14% <88.14%> (ø)
pkg/koordlet/resmanager/types.go 83.00% <96.66%> (+25.43%) ⬆️
pkg/koordlet/resmanager/strategy_util.go 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a83fb3...b2745dd. Read the comment docs.

pkg/util/config.go Outdated Show resolved Hide resolved
@jasonliu747 jasonliu747 requested a review from hormes April 27, 2022 09:28
@jasonliu747
Copy link
Member Author

/cc @saintube

@koordinator-bot
Copy link

@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: saintube.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @saintube

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup_resource.go Outdated Show resolved Hide resolved
pkg/util/system/resctrl.go Outdated Show resolved Hide resolved
pkg/util/system/resctrl_linux.go Outdated Show resolved Hide resolved
pkg/slo-controller/nodeslo/nodeslo_controller_test.go Outdated Show resolved Hide resolved
pkg/slo-controller/nodeslo/nodeslo_controller_test.go Outdated Show resolved Hide resolved
pkg/util/config.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup.go Outdated Show resolved Hide resolved
apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup.go Outdated Show resolved Hide resolved
@jasonliu747
Copy link
Member Author

@saintube
image

@saintube
Copy link
Member

/lgtm

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 29, 2022
@eahydra
Copy link
Member

eahydra commented Apr 29, 2022

/approve

@eahydra
Copy link
Member

eahydra commented Apr 29, 2022

/lgtm

@hormes
Copy link
Member

hormes commented Apr 29, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit dd30303 into koordinator-sh:main Apr 29, 2022
@jasonliu747 jasonliu747 deleted the issue-56 branch April 29, 2022 08:02
@cheimu
Copy link
Member

cheimu commented May 9, 2022

Hi Jason, don't know if I understand this log correctly. It seems like only functionalities are implemented now, but resctrl_reconcile is still not been activated in resmanager.Run(), right? Currently it only been called once in unit tests.

@jasonliu747
Copy link
Member Author

Hi Jason, don't know if I understand this log correctly. It seems like only functionalities are implemented now, but resctrl_reconcile is still not been activated in resmanager.Run(), right? Currently it only been called once in unit tests.

Hi @cheimu , you're absolutely right! I missed to call NewResctrlReconcile in resmanager.Run().
Would you like to submit a PR to fix it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add LLC and MBA isolation stragegy
6 participants