-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ support LLC & MBA isolation #94
Conversation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 47.31% 49.82% +2.50%
==========================================
Files 75 77 +2
Lines 6668 7248 +580
==========================================
+ Hits 3155 3611 +456
- Misses 3198 3309 +111
- Partials 315 328 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/cc @saintube |
@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: saintube. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi Jason, don't know if I understand this log correctly. It seems like only functionalities are implemented now, but resctrl_reconcile is still not been activated in resmanager.Run(), right? Currently it only been called once in unit tests. |
Hi @cheimu , you're absolutely right! I missed to call |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #56
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews