fix cpuinfo panic on arm64 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 44.26% 44.19% -0.08%
==========================================
Files 72 73 +1
Lines 5946 5965 +19
==========================================
+ Hits 2632 2636 +4
- Misses 3019 3036 +17
+ Partials 295 293 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
saintube
force-pushed
the
fix-cpuinfo-panic
branch
from
5628bc9
to
4518132
Compare
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
fix-cpuinfo-panic
branch
from
4518132
to
e923704
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
revise
getProcessorInfos()(inpkg/util/cpuinfo.go) logic on arm64 platform.Ⅱ. Does this pull request fix one issue?
fixes #89 #90 .
Ⅲ. Describe how to verify it
expect no longer panic when running koordlet on arm64
Ⅳ. Special notes for reviews