-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support multi cluster #31
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a1bdf9e
to
0468b3d
Compare
yarnNodeIdAnnotation = "yarn.hadoop.apache.org/node-id" | ||
//yarnNodeNameAnnotation = "node.yarn.koordinator.sh" | ||
yarnNodeAllocatedResourceAnnotationKey = "neptune.xhs.com/resourceAllocated" | ||
actualOfflineResourceAnnotationKey = "neptune.xhs.com/actualOfflineResource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use name like node.yarn.koordinator.sh/neptune.xhs.com/resourceAllocated
@@ -217,10 +216,6 @@ func setupConnection(c *Client) (*connection, error) { | |||
} | |||
|
|||
func writeConnectionHeader(conn *connection, authProtocol yarnauth.AuthProtocol) error { | |||
if err := conn.con.SetDeadline(time.Now().Add(rwDefaultTimeout)); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should keep timeout deadline
@@ -279,7 +270,7 @@ func writeConnectionContext(c *Client, conn *connection, connectionId *connectio | |||
return err | |||
} | |||
|
|||
ipcCtxProtoBytes, err := proto.Marshal(&ipcCtxProto) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err should keep
* filter finished yarn container * yarn resource sync to k8s * yarn node resource metrics Signed-off-by: suozengzeng <suozengzeng@xiaohongshu.com>
0468b3d
to
de69c24
Compare
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the koordinator-sh org. You can then trigger verification by writing
|
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test