Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support multi cluster #31

Closed
wants to merge 1 commit into from
Closed

Conversation

Suozz
Copy link
Collaborator

@Suozz Suozz commented Sep 12, 2023

Ⅰ. Describe what this PR does

  • multi cluster
  • filter finished yarn container
  • yarn resource sync to k8s
  • yarn node resource metrics

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yarnNodeIdAnnotation = "yarn.hadoop.apache.org/node-id"
//yarnNodeNameAnnotation = "node.yarn.koordinator.sh"
yarnNodeAllocatedResourceAnnotationKey = "neptune.xhs.com/resourceAllocated"
actualOfflineResourceAnnotationKey = "neptune.xhs.com/actualOfflineResource"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use name like node.yarn.koordinator.sh/neptune.xhs.com/resourceAllocated

@@ -217,10 +216,6 @@ func setupConnection(c *Client) (*connection, error) {
}

func writeConnectionHeader(conn *connection, authProtocol yarnauth.AuthProtocol) error {
if err := conn.con.SetDeadline(time.Now().Add(rwDefaultTimeout)); err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should keep timeout deadline

@@ -279,7 +270,7 @@ func writeConnectionContext(c *Client, conn *connection, connectionId *connectio
return err
}

ipcCtxProtoBytes, err := proto.Marshal(&ipcCtxProto)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err should keep

* filter finished yarn container
* yarn resource sync to k8s
* yarn node resource metrics
Signed-off-by: suozengzeng <suozengzeng@xiaohongshu.com>
@koordinator-bot
Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the koordinator-sh org. You can then trigger verification by writing /verify-owners in a comment.

  • yarn-copilot-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • pkg/yarn/copilot/OWNERS

@zwzhang0107 zwzhang0107 deleted the support_multi_cluster_remote branch November 17, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants