Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn-operator: add ut for controller #45

Merged
merged 1 commit into from
Oct 26, 2023
Merged

yarn-operator: add ut for controller #45

merged 1 commit into from
Oct 26, 2023

Conversation

zwzhang0107
Copy link
Collaborator

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@Suozz
Copy link
Collaborator

Suozz commented Oct 26, 2023

/lgtm

@zwzhang0107
Copy link
Collaborator Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d347d17 into main Oct 26, 2023
11 checks passed
@zwzhang0107 zwzhang0107 deleted the refactot-dir branch October 26, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants