fix(ui): Migrate to functions #215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - this is a very useful improvemengt, feel free to merge these things yourself. How confident are you we're not gonna regress anything visually? |
jkowalski
approved these changes
Nov 26, 2023
In the best case, there is no regression :-). However, the difficulty is to migrate correctly that everything works. All hooks etc. have to be implemented correctly. We need to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR migrates components to react functions. We do this as React recommends to use functions instead of components. Furthermore, new updates (e.g. react-router-dom) are easier to merge and implement.
Feedback is welcomed.
Cheers,