Skip to content

Commit

Permalink
update the default number of iterations to new paper evaluation; incr…
Browse files Browse the repository at this point in the history 
…ement minor version
  • Loading branch information
Korbinian Eckstein committed May 21, 2024
1 parent 048bd22 commit 48b2b90
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "QuantitativeSusceptibilityMappingTGV"
uuid = "bd393529-335a-4aed-902f-5de61cc7ff49"
authors = ["Korbinian Eckstein korbinian90@gmail.com"]
version = "0.5.0"
version = "0.6.0"

[deps]
FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341"
Expand Down
6 changes: 3 additions & 3 deletions src/tgv.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ end

function get_default_iterations(res, step_size)
# Heuristic formula
it = 2000 # default for res=[1,1,1]
it = 3200 # default for res=[1,1,1]
min_iterations = 1000 # even low res data needs at least 1000 iterations
it = max(min_iterations, it / prod(res)^0.8)
it /= step_size^0.6
it = max(min_iterations, it / prod(res)^0.42)
it /= step_size^0.6 # increasing the step size reduces the required iterations
return round(Int, it)
end

Expand Down

2 comments on commit 48b2b90

@korbinian90
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/107399

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.0 -m "<description of version>" 48b2b904e1973c6e9b2aa4cead4a13f271fc6bc0
git push origin v0.6.0

Also, note the warning: Version 0.6.0 skips over 0.5.0
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

Please sign in to comment.