refactor MainActivity, backport android_native_glue changes from r22 #257

pazos · 2020-10-18T13:50:05Z

Fixed: timeout logic (system timeout wasn't restored on activity paused)
Fixed: code styling issues
Moved: clipboard, device and timeouts to helper classes
Added: utils to manage permissions
Added: manage battery optimizations (API23+)
Changed: non-mandatory permission dialogs are available from lua
Changed: non e-ink devices don't use a SurfaceView
Changed: theme is now material design on compatible android versions (API21+)
Changed: backported android_native_glue changes from NDK r22
Removed: useless warning in AssetsUtils

cf: #253 (comment)

It doesn't involve massive changes in the code but uses modern "material design" dialogs if possible.

Pinging both @Galunid and @zwim: can you test that everything still works fine on your epd devices?

@zwim: lights still work?, epd updates fires fine?
@Galunid: does it build on docker container?, do you see the new light dialog with material style?, Is it legible?

This change is

Galunid · 2020-10-18T13:57:53Z

@pazos I'm building it, I'll let you know what happens. Anything I should pay attention to in particular?

EDIT: I build it using docker successfully! :)

pazos · 2020-10-18T14:03:29Z

Anything I should pay attention to in particular?

A screenshot of the light dialog would be great. Other than that just check that nothing crashes :)

Galunid · 2020-10-18T14:20:13Z

There was some problem with mupdf, it seems I need to clean build (it happened on emulator too), I'll test it in ~1h

Galunid · 2020-10-18T15:11:53Z

Doesn't seem to crash. I'll continue to use it in case something comes up, but all seems good.

Screenshot:

zwim · 2020-10-18T18:01:52Z

@pazos: I will check it, but I will need until Friday, because I have more work due to Corona :-(

pazos · 2020-10-19T15:50:37Z

Last commit on this branch contains changes into the android_native_app_glue that affect the frontend.

We were reacting to APP_CMD_WINDOW_REDRAW_NEEDED even when that callback was never fired. So, to prevent undefined behaviour in KOReader, the following change is needed:

diff --git a/frontend/device/android/device.lua b/frontend/device/android/device.lua
index c5530ffd..e9d93488 100644
--- a/frontend/device/android/device.lua
+++ b/frontend/device/android/device.lua
@@ -135,9 +135,14 @@ function Device:init()
             if ev.code == C.APP_CMD_SAVE_STATE then
                 return "SaveState"
             elseif ev.code == C.APP_CMD_GAINED_FOCUS
-                or ev.code == C.APP_CMD_INIT_WINDOW
-                or ev.code == C.APP_CMD_WINDOW_REDRAW_NEEDED then
+                or ev.code == C.APP_CMD_INIT_WINDOW then
                 this.device.screen:_updateWindow()
+            elseif ev.code == C.APP_CMD_WINDOW_REDRAW_NEEDED then
+                logger.dbg("APP_CMD_WINDOW_REDRAW_NEEDED")
+            elseif ev.code == C.APP_CMD_WINDOW_RESIZED then
+                logger.dbg("APP_CMD_WINDOW_RESIZED")
+            elseif ev.code == C.APP_CMD_CONTENT_RECT_CHANGED then
+                logger.dbg("APP_CMD_CONTENT_RECT_CHANGED")
             elseif ev.code == C.APP_CMD_CONFIG_CHANGED then
                 -- orientation and size changes
                 if android.screen.width ~= android.getScreenWidth()

The rest of changes shouldn't affect KO behaviour, but it is cool to log them anyways.

zwim · 2020-10-21T17:55:46Z

@pazos: This PR seems to work. I have noticed no problem.

pazos · 2020-10-21T18:37:03Z

This PR seems to work. I have noticed no problem.

Thank you for testing!. Some questions:

Did you applied #257 (comment)? If not I assume you didn't find any difference on the behaviour (ie: when returning to the activity, when closing the frontlight dialog ...)

Does the frontlight dialog looks any different?. It shouldn't if the firmware is older than Lollipop. But if it looks the same and works the same is a big win (and what's expected based on what I saw on old emulators)

zwim · 2020-10-21T19:53:06Z

On 4.4.2 (Tolino) I did not notice any difference.
Android dialog looks the same.

…tform/ndk/+/1180321 some APP_CMDs callbacks were never triggered: APP_CMD_WINDOW_RESIZED / APP_CMD_WINDOW_REDRAW_NEEDED / APP_CMD_CONTENT_RECT_CHANGED See android/ndk#1139

pazos · 2020-10-31T17:15:19Z

@Frenzie: still waiting your review :)

NiLuJe · 2020-10-31T17:22:56Z

I think he's still in the "just moved" frenzy (ha!), and may not yet have a stable landline ;).

pazos · 2020-10-31T17:40:06Z

I think he's still in the "just moved" frenzy (ha!), and may not yet have a stable landline ;).

I can wait. Is just that I have another pile or changes to submit and don't want to push on top of this, yet.

Frenzie · 2020-11-01T17:56:48Z

I have a stable line, but no time. But I'll check if it's short.

…

On Saturday, October 31, 2020, Martín Fernández ***@***.***> wrote: I think he's still in the "just moved" frenzy (ha!), and may not yet have a stable landline ;). I can wait. Is just that I have another pile or changes to submit and don't want to push on top of this, yet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRQBKXOI7A3BGKI5WNF43SNRDYDANCNFSM4SVDDL2A> .

Frenzie

Looks fairly straightforward; didn't have time to check in the Android docs for some of the new (at least to us) calls/constants of which I don't know exactly what they're doing though.

Frenzie · 2020-11-01T20:07:40Z

app/src/org/koreader/launcher/MainApp.kt

+        val hasLargeHeap = (applicationInfo.flags and ApplicationInfo.FLAG_LARGE_HEAP != 0)
+        val isDebuggable = (applicationInfo.flags and ApplicationInfo.FLAG_DEBUGGABLE != 0)
+        val isSystemApp = (applicationInfo.flags and ApplicationInfo.FLAG_SYSTEM == 1)


What are these for exactly? :-)

Build flags. Used for logging mainly. They're all booleans.

hasLargeHeap can be removed, because it was added to log the size of the dalvik VM heap when we disabled largeHeap app property. Nobody reported a crash due to a not enough dalvik heap size.

pazos · 2020-11-01T20:28:20Z

Looks fairly straightforward; didn't have time to check in the Android docs for some of the new (at least to us) calls/constants of which I don't know exactly what they're doing though.

Probably there's nothing very new. Just a few minor changes:

We start activities (dictionary apps, browser, ...) using NO_ANIMATION flag, to prevent the animation during activity transition.
Add a couple of api calls to check if the battery is optimized and to change that.
Permission code was refactored to be easily upgraded for new api requirements.

The size of the APK grows about 800kb because of the new required library "androidx.appcompat:appcompat". That's probably the last app size grow that's caused by android dependencies.

refactored runtime permissions, almost API30 ready. simplified MainApp Added: manage battery optimizations (API23+) Fixed: code styling issues Changed: non-mandatory permission dialogs are available from lua Changed: non e-ink devices don't use a SurfaceView Changed: theme is now material design on compatible android versions (API21+) Changed: disabled animations while switching tasks Removed: useless logs in AssetsUtils, unused manifest properties

- Lcd devices won't use the SurfaceView, just the good old native content/window (except AndroidTv and ChromeOS) - All android dialogs will be presented with Material Design on recent devices. - Added an option to device settings to manage application battery optimization. - Permissions that require the user to go to a settings page will be presented with a native android dialog. - bump android-luajit-launcher - Changes under the hood: koreader/android-luajit-launcher#257

pazos requested a review from Frenzie October 18, 2020 13:50

Galunid mentioned this pull request Oct 18, 2020

Return Wifi when VPN and Wifi are conencted #252

Closed

pazos force-pushed the android_helpers branch from 6c2a2ca to 27da05c Compare October 18, 2020 22:55

pazos mentioned this pull request Oct 19, 2020

bump to API 30 #253

Merged

pazos force-pushed the android_helpers branch from 03791ea to bd2d55d Compare October 20, 2020 12:15

pazos mentioned this pull request Oct 21, 2020

Implement EPD Controller for newer Onyx Boox devices (Qualcomm) #250

Merged

backport glue from r22: https://android-review.googlesource.com/c/pla…

4fb55d9

…tform/ndk/+/1180321 some APP_CMDs callbacks were never triggered: APP_CMD_WINDOW_RESIZED / APP_CMD_WINDOW_REDRAW_NEEDED / APP_CMD_CONTENT_RECT_CHANGED See android/ndk#1139

pazos force-pushed the android_helpers branch 2 times, most recently from 98f8bee to efe9b8c Compare October 24, 2020 14:59

pazos mentioned this pull request Oct 24, 2020

android changes koreader/koreader#6821

Merged

pazos changed the title ~~get rid of BaseActivity, refactor some code on helper classes, …~~ refactor MainActivity, backport android_native_glue changes from r22 Oct 24, 2020

pazos force-pushed the android_helpers branch from efe9b8c to a920c2f Compare October 26, 2020 22:09

Frenzie approved these changes Nov 1, 2020

View reviewed changes

pazos force-pushed the android_helpers branch from bdc4c53 to f79335c Compare November 1, 2020 21:26

pazos force-pushed the android_helpers branch from f79335c to 639bdb2 Compare November 1, 2020 23:59

pazos merged commit f2d946b into koreader:master Nov 3, 2020

pazos deleted the android_helpers branch December 19, 2020 19:06

pazos mentioned this pull request Jan 14, 2021

Multiwindow / free mode support. #238

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor MainActivity, backport android_native_glue changes from r22 #257

refactor MainActivity, backport android_native_glue changes from r22 #257

pazos commented Oct 18, 2020 •

edited

Loading

Galunid commented Oct 18, 2020 •

edited

Loading

pazos commented Oct 18, 2020

Galunid commented Oct 18, 2020

Galunid commented Oct 18, 2020

zwim commented Oct 18, 2020

pazos commented Oct 19, 2020

zwim commented Oct 21, 2020

pazos commented Oct 21, 2020

zwim commented Oct 21, 2020

pazos commented Oct 31, 2020

NiLuJe commented Oct 31, 2020

pazos commented Oct 31, 2020

Frenzie commented Nov 1, 2020 via email

Frenzie left a comment

Frenzie Nov 1, 2020

pazos Nov 1, 2020

pazos commented Nov 1, 2020

refactor MainActivity, backport android_native_glue changes from r22 #257

refactor MainActivity, backport android_native_glue changes from r22 #257

Conversation

pazos commented Oct 18, 2020 • edited Loading

Galunid commented Oct 18, 2020 • edited Loading

pazos commented Oct 18, 2020

Galunid commented Oct 18, 2020

Galunid commented Oct 18, 2020

Screenshot:

zwim commented Oct 18, 2020

pazos commented Oct 19, 2020

zwim commented Oct 21, 2020

pazos commented Oct 21, 2020

zwim commented Oct 21, 2020

pazos commented Oct 31, 2020

NiLuJe commented Oct 31, 2020

pazos commented Oct 31, 2020

Frenzie commented Nov 1, 2020 via email

Frenzie left a comment

Choose a reason for hiding this comment

Frenzie Nov 1, 2020

Choose a reason for hiding this comment

pazos Nov 1, 2020

Choose a reason for hiding this comment

pazos commented Nov 1, 2020

pazos commented Oct 18, 2020 •

edited

Loading

Galunid commented Oct 18, 2020 •

edited

Loading