Add a few RGB-aware set & blend methods to the blitters #1680
Commits on Aug 25, 2024
-
-
(Jokes aside, we tend to prefer that syntatcit sugar (and string methods) as opposed to calling string.fn(obj) explicitly).
-
-
-
A dumb MUL blend works extremely well for blakc text.
It'll get funkier with colors, but, oh, well.
-
-
-
-
-
Start rationalizing the C BB implementations
Replace BB_blend_rect_color w/ BB_blend_RGB_multiply_rect
-
-
-
-
We need it from inside a Document class, and having it split between ReaderHighlights and BB is weird anyway
-
-
-
Address a 10-year old TODO, and properly rename dimRect & lightenRect
methods... (Into lightenRect & darkenRect, respectively). c.f, 2cb2e40
-
Keep revamping the whole thing so it actually has a chance of working
with the Lua blitter...
-
-
-
Implement setPixelColorizeRGB32 in the Lua blitter
Requires a few bendRGB32 shims for Color <= 8A, as the usual blend methods assume Color8 input.
-
And implement setPixelMultiply in the Lua blitter
Which is the one we actually care about, as we don't actually have any colorblitFromRGB32 callers ;).
-
-
Simplify setPixelColorizeRGB32
Implement a grayscale and a color one, like other setters Instead of implementing a full array of per-color type blend methods
-
-
-
And round the component values to 16 shades per component.
-
Make sure we cast colors to the right type first
We often need a copy anyway, so take the opportunity to make this safer ;)
-
-
Drop gray from the highlight colors, and let colorFromName return
nilThis allows us to fairly easily make gray behave as our legacy grayscale highlights, honoring the user's opacity value.
Commits on Aug 26, 2024
-
Matches what I did for BB_color_blit_from_RGB32
-
-
-
Fix a truckload of -Wtype-limits warnings
These are unsigned, they can't be negative ;).
-
Increase the alignment constraint on Kobo MTK
Apparently, 8 wasn't enough, the highlight style dialog was still cutoff :/
-
-
Oh, no, I'd just forgotten that we enforced different constraints when
dithering. So, rejig that so we can tweak that on a per-device basis, too.