-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mupdf: expand list of supported CSS color names #1894
mupdf: expand list of supported CSS color names #1894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised they don't have those upstream. They're liable to turn up sooner rather than later.
Was dictionary rendered by something else than mupdf before the big upgrade? I remember |
Not that I'm aware, no. |
It wouldn't have worked, no. This list of colors dates back a decade to the very first implementation: ArtifexSoftware/mupdf@bb875f7 |
@benoit-pierre Do you still have remaining concerns about this? It looks straightforward and obvious to me. :-) |
0cede9b
to
a594748
Compare
@ptrm: where you able to confirm this fix your invisible |
a594748
to
523095c
Compare
koreader/koreader-base#1894 koreader/koreader-base#1908 koreader/koreader-base#1909 koreader/koreader-base#1904 koreader/koreader-base#1910 koreader/koreader-base#1911 koreader/koreader-base#1912 koreader/koreader-base#1901 koreader/koreader-base#1913 koreader/koreader-base#1680 koreader/koreader-base#1915 koreader/koreader-base#1916 koreader/koreader-base#1914
koreader/koreader-base#1894 koreader/koreader-base#1908 koreader/koreader-base#1909 koreader/koreader-base#1904 koreader/koreader-base#1910 koreader/koreader-base#1911 koreader/koreader-base#1912 koreader/koreader-base#1901 koreader/koreader-base#1913 koreader/koreader-base#1680 koreader/koreader-base#1915 koreader/koreader-base#1916 koreader/koreader-base#1914
Cf. koreader/koreader#12158 (comment)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)