-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: improved binaries check + fix kindle-legacy / pocketbook build #1905
Conversation
d8c3dc6
to
733d218
Compare
And another regression caught:
Looks like tar is not the only potential user. |
As well as:
and
|
That's for pocketbook, no issue with Which is missing from Circle CI's matrix, how about adding it? |
Tentative patch for the remaining pocketbook issue: input/input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git i/input/input.c w/input/input.c
index 5414d301e..764afa3af 100644
--- i/input/input.c
+++ w/input/input.c
@@ -125,7 +125,7 @@ static int openInputDevice(lua_State* L)
if (!strcmp("fake_events", inputdevice)) {
// Special case: the power slider for Kindle and USB events for Kobo.
int pipefd[2U];
-#if defined(KINDLE_LEGACY)
+#if defined(KINDLE_LEGACY) || defined(POCKETBOOK)
// pipe2 requires Linux 2.6.27 & glibc 2.9...
if (pipe(pipefd) == -1) {
return luaL_error(L, "Cannot create fake event generator communication pipe (pipe(): %s)", strerror(errno)); |
Yup, lgtm! (Note that we no longer actually use the Lua/C input module on PB, but keeping it functional usually costs us nothing ;p). |
For context, this sort of stuff should mostly only happen on kindle-legacy & pocketbook, because they run glibc 2.5, but the toolchain is built against 2.9 (because good luck building 2.5, especially with even a halfway recent GCC version). For the rest of our targets, the ct-ng config will target the "proper" glibc version directly. Note that even that is a moving target, because vendors will sometime miraculously update it ;). e.g., kindle5 & kindlepw2 target 2.12.2, but it was actually updated to 2.19 on FW 5.6.5. (And it was probably updated again for the hf switch, but I lost track ;p). Similarly, kobo targets 2.15, but it was updated to 2.19 (surprise!) on FW 4.6. And will be (massively) updated to 2.3x (can't recall the exact one right now) on 5.0. |
Sure, makes sense. It's likely to overlap very strongly with PB but it's not identical. |
4be8245
to
dbeea69
Compare
Add `--glibc-version-max` to gate the maximum supported GLIBC version: bincheck will fail on libraries that link with more recent symbols.
Avoid pulling-in `__sched_cpucount@GLIBC_2.6`.
Avoid pulling-in `utimensat@@GLIBC_2.6` in `sftp-server`.
Really disable eventfd support…
Don't pull-in `pipe2@GLIBC_2.9`.
Since it's an old platform, take advantage of `bincheck` to detect possible regressions.
dbeea69
to
e35c00b
Compare
--glibc-version-max
to gate the maximum supported GLIBC version: bincheck will fail on libraries that link with more recent symbols.__sched_cpucount@GLIBC_2.6
.This change is