fix cmake 3.31 warnings #1973
Merged
fix cmake 3.31 warnings #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 3.31: ``` Compatibility with CMake < 3.10 will be removed from a future version of CMake. ```
With 3.31: ``` Keyword WORKING_DIRECTORY requires a value, but none was given. Policy CMP0175 is not set: add_custom_command() rejects invalid arguments. Run "cmake --help-policy CMP0175" for policy details. Use the cmake_policy command to set the policy and suppress this warning Keyword WORKING_DIRECTORY requires a value, but none was given. ``` Additionally, make calls to `add_custom_command` stricter starting with 3.31.
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Nov 11, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 11, 2024
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is