mupdf: fix finalizers #2001
Merged
mupdf: fix finalizers #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the MuPDF tests segfault on quit pretty regularly (e.g.: `make --assume-old=all test T='mupdf -f jbig'`), this is because there's no guarantee that the context used to open a document or page won't be dropped before that document / page is. Use the context private user pointer to keep a reference count and ensure it's only dropped last.
Use a weak reference to allow for garbage collection.
benoit-pierre
force-pushed
the
pr/fix_mupdf_finalizers
branch
from
26a34c6 to
06e7f2c
Compare
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Dec 11, 2024
Includes: * sqlite: update to 3.47.2 (koreader/koreader-base#1999) * mupdf: fix finalizers (koreader/koreader-base#2001) * mupdf: allow memory streams to load resources (koreader/koreader-base#2002) for #12877 * thirdparty/lua-Spore 0.3.4 (koreader/koreader-base#2003)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the MuPDF tests segfault on quit pretty regularly (e.g.:
make --assume-old=all test T='mupdf -f jbig'), this is because there's no guarantee that the context used to open a document or page won't be dropped before that document / page is.Use the context private user pointer to keep a reference count and ensure it's only dropped last.
This change is