Support access control options

[Mikescops]

Hello,

I'm trying to implement the support of the Keychain Item Accessibility (see Apple documentation here).

The goal is for instance to ask for user presence (faceId, touchId) when requesting a password from the keychain. This options are widely supported on ios/macos/tvos/... so I thought it makes sense to include it in this library.

Disclaimer: I'm not familiar with Rust at all, so I did my best to get into it, here is a draft so let me know if I'm heading in the right direction and any guidance/help is welcomed!

I didn't added tests yet, didn't want to spend too much time if I'm already not doing things right

[kornelski]

Thanks for the PR.

I'm happy to add more of the security framework functionality, but I'd prefer not to make breaking changes to existing Rust APIs. If you need to modify existing tests to compile the code, that's a breaking change.

[Mikescops]

If you need to modify existing tests to compile the code, that's a breaking change.

Totally agree, thanks for the tips!

[Mikescops]

@kornelski I tried to make your suggestions, I think I got something decent

It's not touching the function signatures, and the tests are passing, i restructured the password options (hope it's what you wanted).

Now I'm not sure exactly how to expose my new set_access_control_options method to the outside, looking for your advice

[dmolokanov]

@Mikescops / @kornelski Do you guys have plans to merge this PR.

[Mikescops]

@dmolokanov I'd love to do so yes, but i need feedback first

[kornelski]

Looks good, thank you.

[gibfahn]

The goal is for instance to ask for user presence (faceId, touchId) when requesting a password from the keychain. This options are widely supported on ios/macos/tvos/... so I thought it makes sense to include it in this library.

Came here looking for the same thing, biometric support for keychain passwords.

Seems that this PR added PasswordOptions, but I can't find a way to actually plumb them in to the generic password creation API.

use security_framework::passwords_options::{AccessControlOptions, PasswordOptions};

fn main() {
    let access_control_options = AccessControlOptions::USER_PRESENCE;
    let mut entry = PasswordOptions::new_generic_password("my_service3", "test1");
    entry.set_access_control_options(access_control_options);
    // How to actually use this?
}

This example also errors with:

called Result::unwrap() on an Err value: Error { code: -50, message: "One or more parameters passed to a function were not valid." }

which comes from security-framework-2.9.2/src/passwords_options.rs:124:13