Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TensorView #109

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Implement TensorView #109

merged 5 commits into from
Aug 29, 2024

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Aug 26, 2024

  • implement a TensorView struct to leverage axes permutations
  • implement as_ptr / get / get_unchecked in TensorStorage
  • expose as_ptr in Tensor
  • return TensorView in Tensor::reshape
  • implement Tensor::permute_axes and return TensorView
  • implement Tensor::view to return TensorView
  • Tensor::get now returns Option to align with Arrow and ndarray
  • added some of tests

@edgarriba edgarriba marked this pull request as ready for review August 28, 2024 17:11
@edgarriba edgarriba changed the title [wip] Implement TensorView Implement TensorView Aug 28, 2024
@edgarriba
Copy link
Member Author

@liamkinne maybe you want to help to review this PR ?

@edgarriba edgarriba merged commit ded11ca into main Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant