Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify handling paths by using impl AsRef<Path> for JPEG functions #111

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Simplify handling paths by using impl AsRef<Path> for JPEG functions #111

merged 1 commit into from
Aug 28, 2024

Conversation

liamkinne
Copy link
Contributor

This is common in other libraries and allows Path, PathBuf, &str and String to be passed into the function and automatically converted to a Path.

edgarriba
edgarriba approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it ! thanks !

@edgarriba edgarriba merged commit 5bb9cad into kornia:main Aug 28, 2024
9 checks passed
@liamkinne liamkinne deleted the simplify-path branch August 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarriba edgarriba edgarriba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamkinne @edgarriba