Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ndarray phase1 #114

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Deprecate ndarray phase1 #114

merged 8 commits into from
Aug 30, 2024

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Aug 30, 2024 •
edited
Loading

  • the kornia-image Image trait now is a tuple struct based on Tensor3
  • TensorStorage::from_vec is not Result anymore as is safe
  • make temporary as_mut_ptr untill we remove ndarray::ArrayView3 from kornia-imgproc
  • move abs / mean implementation to Tensor
  • Implement kornia-imgproc using ndarray::ArrayView3 until we replace the parallel for loops
  • update tests and examples
  • update pyo3 to 0.21.2 and fix python bindings

@edgarriba edgarriba marked this pull request as ready for review August 30, 2024 20:28
@edgarriba edgarriba merged commit be59200 into main Aug 30, 2024
9 checks passed
@edgarriba edgarriba deleted the deprecate-ndarray-phase1 branch January 2, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edgarriba