-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new crate for core-ops #142
Conversation
@edgarriba do you want the operations currently defined in |
possibly wiht a TensorOps trait but let's explore this later. Put a first an initial crate with something simple and we keep iterating |
Ok. Should I start with something simple that is not yet implemented or something that is already implement for Tensor? |
maybe the norm operator needed by cosine distance |
I started with the norm operator but then realised it needed the |
Marked this as ready for review so that the new core-ops crate can be merged without being blocked by all the ops that need to be implemented. I you would rather want this to be a bigger PR with more ops added first, I can change the status to draft and work on it further. |
@jandremarais any progress here ? we can land step by step and keep improving |
I will work on this tonight (UTC +2). I will remove the dynamic shape stuff, add docs to sum_elements and put the DimOutOfBounds error in TensorError. |
@jandremarais sound good -- consider this too apache/arrow-rs#6492 (comment). I might be working on a PR for it during the week. Arrow seems pretty unflexible, so maybe we should go for our full implementation |
@edgarriba I addressed all of your comments in the latest commits. Open to further feedback if I interpreted anything incorrectly or if there are any new suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make a rebase and all good !
6f657e1
to
7020960
Compare
Separate the core tensor operations from the core crate to a core-ops crate.