Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor display #146

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Tensor display #146

merged 2 commits into from
Sep 25, 2024

Conversation

jandremarais
Copy link
Contributor

implement Display for Tensor

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Improvements can be done later

" [ 5, 6]],",
"",
" [[ 7, 8],",
" [ 9,10],",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe with a space too here ?


#[rustfmt::skip]
assert_eq!(lines.as_slice(),
["[[[0,0,0,...,0],",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be done later, but playing around with numpy/torch i've noticed that the magic number to truncate output is 10

image
image

@edgarriba edgarriba merged commit cd85c52 into kornia:main Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants