[prototype] ImageDtype
trait to implement resize for various dtypes
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my prototype to support resize with different dtypes. Justifications for trait
Copy
trait: to get the value out ofndarray::Array<T, _>
Default
trait: to get 0 valueInto<f32>
trait: to convert to f32 for internal computation i.e. bilinear/bicubicSend
andSync
trait: required forndarray::Zip::par_for_each()
from_f32()
function: convert from internal computation dtype f32 back to original dtype. We can't useFrom<f32>
since it is undefined-behavior with underflow and overflow values i.e. we need to clamp the value by ourselves.I think
ImageDtype
trait can be moved toimage.rs
and data withinImage
must implementImageDtype
trait i.e. these are the dtype that we support ->pub struct Image<T: ImageDtype, const CHANNELS: usize>