Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rotate example #69

Merged
merged 1 commit into from
Apr 3, 2024
Merged

add rotate example #69

merged 1 commit into from
Apr 3, 2024

Conversation

edgarriba
Copy link
Member

rotate.mp4

@edgarriba
Copy link
Member Author

@gau-nernst

@gau-nernst
Copy link
Contributor

There is one problem with my implementation that I forgot to mention. As you can see, the edges are jagged. This is because I skip pixels if they are outside of the original image, which will create aliasing effect. To make smooth edges, we need add different modes of handling the border (1) clamp to edge of the image (as right now) is suitable for resizing, and (2) return zero so that we can still interpolate the few pixels outside the image.
I think for now we can just open an issue to keep track of the problem.
It will be good to also look into OpenCV implementation.

@edgarriba
Copy link
Member Author

Yeah, I’m also looking at https://github.com/rust-lang/portable-simd because there are a lot of operations that can be vectorized

@edgarriba edgarriba merged commit b8934de into main Apr 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants