Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rotation and translation classmethods in se3 and so3 #2001

Merged
merged 5 commits into from
Nov 15, 2022
Merged

add rotation and translation classmethods in se3 and so3 #2001

merged 5 commits into from
Nov 15, 2022

Conversation

edgarriba
Copy link
Member

@edgarriba edgarriba commented Nov 12, 2022 •
edited
Loading

Changes

Adds:

  • rot_x , rot_y , rot_z in So3 and Se3
  • trans, trans_x, trans_y and trans_z in Se3

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba edgarriba changed the title add rot_x in se3 and so3 add rotation and translation classmethods in se3 and so3 Nov 12, 2022
@edgarriba edgarriba marked this pull request as ready for review November 12, 2022 20:56
@edgarriba @cjpurackal
Apply suggestions from code review
78e6f13 
Co-authored-by: Christie Jacob <christeejacobs@gmail.com>
@edgarriba edgarriba added enhancement 🚀 Improvement over an existing functionality PR: Good to Merge 👌 module: geometry labels Nov 15, 2022
@edgarriba edgarriba merged commit 4ac08b1 into master Nov 15, 2022
@edgarriba edgarriba deleted the se3-improvements branch November 15, 2022 19:04
johnnv1 pushed a commit to johnnv1/kornia that referenced this pull request Apr 5, 2023
@edgarriba @cjpurackal
add rotation and translation classmethods in se3 and so3 (kornia#2001)
15a4a32 
* add rot_x

* implement roty, rotz, trans, transx, transy, transz

* small improvement

* improve quaternion exposure

* Apply suggestions from code review

Co-authored-by: Christie Jacob <christeejacobs@gmail.com>

Co-authored-by: Christie Jacob <christeejacobs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpurackal cjpurackal cjpurackal approved these changes

@ducha-aiki ducha-aiki Awaiting requested review from ducha-aiki

@lferraz lferraz Awaiting requested review from lferraz

Assignees
No one assigned
Labels
enhancement 🚀 Improvement over an existing functionality module: geometry PR: Good to Merge 👌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarriba @cjpurackal