Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release v1] Comment on PR when target branch not found #311

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

korthout
Copy link
Owner

@korthout korthout commented Dec 26, 2022

Manual backport to release-v1 of

Manually created because of:

When the target cannot be found on remote, then the git fetch fails
with: (example for `maintenance/8.1`)
```
fatal: couldn't find remote ref maintenance/8.1
'git fetch origin maintenance/8.1' failed with exit code 128
```

We can improve this by throwing a special error and handling it
explicitly by commenting on the original pull request about this
situation. We can also help the user figure out how to resolve the
problem by making it clear that a branch with that name should exist.

(cherry picked from commit f16f704)
@korthout korthout merged commit fafece9 into release-v1 Dec 26, 2022
@korthout korthout deleted the backport-310-to-release-v1 branch December 26, 2022 12:13
@korthout korthout linked an issue Dec 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error comment when target branch doesn't exist
1 participant