Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigurableDI.addExtend should take a copy parameter #395

Closed
dalewking opened this issue Dec 9, 2021 · 0 comments
Closed

ConfigurableDI.addExtend should take a copy parameter #395

dalewking opened this issue Dec 9, 2021 · 0 comments

Comments

@dalewking
Copy link

The function:

    public fun addExtend(di: DI, allowOverride: Boolean = false): Unit = addConfig { extend(di, allowOverride) }

is a nice shortcut, but it doesn't allow you to use if if you need to pass the copy parameter to extend.

A third parameter should be added for copy that defaults to the current behavior, i.e.

    public fun addExtend(di: DI, allowOverride: Boolean = false, copy: Copy = Copy.NonCached): Unit =
         addConfig { extend(di, allowOverride, copy) }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants