Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Integrate end-to-end workflows #239

Merged
merged 1 commit into from
Nov 17, 2023
Merged

E2E: Integrate end-to-end workflows #239

merged 1 commit into from
Nov 17, 2023

Conversation

lvtaococo
Copy link
Contributor

@lvtaococo lvtaococo commented Nov 13, 2023 •
edited
Loading

What type of PR is this?

/kind e2e

What does this PR do?

Integrate end-to-end workflows

Which issue(s) does this PR fix?

Fixes #236

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@kosmos-robot
Copy link
Contributor

@lvtaococo: The label(s) kind/documentation cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind documentation

What does this PR do?

Integrate end-to-end workflows

Which issue(s) does this PR fix?

Fixes #236

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuyingjun-lucky wuyingjun-lucky changed the title docs: Integrate end-to-end workflows E2E: Integrate end-to-end workflows Nov 14, 2023
@wuyingjun-lucky
Copy link
Member

/kind e2e

wuyingjun-lucky
wuyingjun-lucky reviewed Nov 14, 2023
View reviewed changes
.github/workflows/e2e.yml Outdated
if: failure()
with:
name: kosmos-e2e-logs-${{ github.run_id }}
path: ${{ github.workspace }}/e2e-test/logs-*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@lvtaococo lvtaococo force-pushed the feature_e2e_workflows branch 4 times, most recently from 55db367 to 8fe34fd Compare November 17, 2023 01:42
@lvtaococo
feat: Integrate end-to-end workflows
ef9107d 
Signed-off-by: lvtaococo <lvtao_yewu@cmss.chinamobile.com>
@wuyingjun-lucky
Copy link
Member

/approve
/lgtm

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lvtaococo, wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit 4cd6ef9 into kosmos-io:main Nov 17, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuyingjun-lucky wuyingjun-lucky wuyingjun-lucky left review comments

@wangyizhi1 wangyizhi1 Awaiting requested review from wangyizhi1

Assignees

@wuyingjun-lucky wuyingjun-lucky

Labels
approved kind/e2e lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate end-to-end workflows
3 participants
@lvtaococo @kosmos-robot @wuyingjun-lucky