feat: Script supports installing kind and kubectl #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanmengkk
reviewed
Nov 15, 2023
| @@ -49,7 +49,7 @@ spec: | |||
| containers: | |||
| - name: clustertree-cluster-manager | |||
| image: ghcr.io/kosmos-io/clustertree-cluster-manager:__VERSION__ | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
the verison is latest,so Always is better?
There was a problem hiding this comment.
The "latest" image hasn't been pushed to the remote repository.
duanmengkk
reviewed
Nov 15, 2023
hack/install-go.sh
Outdated
| install_go | ||
| fi | ||
|
|
||
| echo "Go is installed and the version is correct." |
duanmengkk
reviewed
Nov 15, 2023
hack/install_kind_kubectl.sh
Outdated
| else | ||
| echo "not pass" | ||
| util::install_kubectl "" "${BS_ARCH}" "${BS_OS}" | ||
| fi |
lvtaococo
force-pushed
the
feature_script_modify
branch
from
e63fc55
to
4c34f0d
Compare
Signed-off-by: lvtaococo <lvtao_yewu@cmss.chinamobile.com>
lvtaococo
force-pushed
the
feature_script_modify
branch
from
4c34f0d
to
8b05c1c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lvtaococo, wuyingjun-lucky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
Script supports installing kind and kubectl.
Which issue(s) does this PR fix?
Fixes #250
Special notes for your reviewer:
Does this PR introduce a user-facing change?