Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter nodeconfig event before reconcile #267

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

OrangeBao
Copy link
Contributor

What type of PR is this?

/kind bug

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Signed-off-by: OrangeBao <baoyinghai_yewu@cmss.chinamobile.com>
@OrangeBao
Copy link
Contributor Author

/cc @Wangyizhi @ONE7live

@kosmos-robot
Copy link
Contributor

@OrangeBao: GitHub didn't allow me to request PR reviews from the following users: wangyizhi.

Note that only kosmos-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Wangyizhi @ONE7live

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuyingjun-lucky
Copy link
Member

Seems good

@wuyingjun-lucky
Copy link
Member

/approve
/lgtm

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OrangeBao, wuyingjun-lucky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit 19b5cda into kosmos-io:main Nov 20, 2023
5 of 6 checks passed
@OrangeBao OrangeBao deleted the fix_nodeconfig branch June 27, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants