Merge pull request #24512 from WikusKriek/24265-Suggestion-list-not-d… #16
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Process new code merged to main | |
| on: | |
| push: | |
| branches: [main] | |
| jobs: | |
| typecheck: | |
| uses: Expensify/App/.github/workflows/typecheck.yml@main | |
| lint: | |
| uses: Expensify/App/.github/workflows/lint.yml@main | |
| test: | |
| uses: Expensify/App/.github/workflows/test.yml@main | |
| confirmPassingBuild: | |
| runs-on: ubuntu-latest | |
| needs: [typecheck, lint, test] | |
| if: ${{ always() }} | |
| steps: | |
| - if: ${{ needs.typecheck.result == 'failure' || needs.lint.result == 'failure' || needs.test.result == 'failure' }} | |
| uses: Expensify/App/.github/actions/composite/announceFailedWorkflowInSlack@main | |
| with: | |
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} | |
| - if: ${{ needs.typecheck.result == 'failure' || needs.lint.result == 'failure' || needs.test.result == 'failure' }} | |
| run: exit 1 | |
| chooseDeployActions: | |
| runs-on: ubuntu-latest | |
| needs: confirmPassingBuild | |
| outputs: | |
| MERGED_PR: ${{ steps.getMergedPullRequest.outputs.number }} | |
| SHOULD_DEPLOY: ${{ steps.shouldDeploy.outputs.SHOULD_DEPLOY }} | |
| steps: | |
| - name: Get merged pull request | |
| id: getMergedPullRequest | |
| uses: actions-ecosystem/action-get-merged-pull-request@59afe90821bb0b555082ce8ff1e36b03f91553d9 | |
| with: | |
| github_token: ${{ github.token }} | |
| - name: Check if StagingDeployCash is locked | |
| id: isStagingDeployLocked | |
| uses: Expensify/App/.github/actions/javascript/isStagingDeployLocked@main | |
| with: | |
| GITHUB_TOKEN: ${{ github.token }} | |
| - name: Check if merged pull request should trigger a deploy | |
| id: shouldDeploy | |
| run: echo "SHOULD_DEPLOY=${{ (!fromJSON(steps.isStagingDeployLocked.outputs.IS_LOCKED) && github.actor != 'OSBotify') }}" >> "$GITHUB_OUTPUT" | |
| skipDeploy: | |
| runs-on: ubuntu-latest | |
| needs: chooseDeployActions | |
| if: ${{ !fromJSON(needs.chooseDeployActions.outputs.SHOULD_DEPLOY) && github.actor != 'OSBotify' }} | |
| steps: | |
| - name: Comment on deferred PR | |
| uses: actions-ecosystem/action-create-comment@cd098164398331c50e7dfdd0dfa1b564a1873fac | |
| with: | |
| github_token: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| number: ${{ needs.chooseDeployActions.outputs.MERGED_PR }} | |
| body: | | |
| :hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. | |
| createNewVersion: | |
| needs: chooseDeployActions | |
| if: ${{ fromJSON(needs.chooseDeployActions.outputs.SHOULD_DEPLOY) }} | |
| uses: Expensify/App/.github/workflows/createNewVersion.yml@main | |
| secrets: inherit | |
| updateStaging: | |
| needs: [chooseDeployActions, createNewVersion] | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: softprops/turnstyle@ca99add00ff0c9cbc697d22631d2992f377e5bd5 | |
| with: | |
| poll-interval-seconds: 10 | |
| env: | |
| GITHUB_TOKEN: ${{ github.token }} | |
| - uses: actions/checkout@v3 | |
| with: | |
| ref: main | |
| token: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| - uses: Expensify/App/.github/actions/composite/setupGitForOSBotify@main | |
| with: | |
| GPG_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} | |
| - name: Update staging branch from main | |
| run: | | |
| # Re-create the staging branch from main | |
| git switch -c staging | |
| # Force-update the remote staging branch | |
| git push --force origin staging | |
| # Create a local git tag on staging so that GitUtils.getPullRequestsMergedBetween can use `git log` to generate a | |
| # list of pull requests that were merged between this version tag and another. | |
| # NOTE: This tag is only used locally and shouldn't be pushed to the remote. | |
| # If it was pushed, that would trigger the staging deploy which is handled in a separate workflow (deploy.yml) | |
| - name: Tag staging | |
| run: git tag ${{ needs.createNewVersion.outputs.NEW_VERSION }} | |
| - name: Update StagingDeployCash | |
| uses: Expensify/App/.github/actions/javascript/createOrUpdateStagingDeploy@main | |
| with: | |
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| NPM_VERSION: ${{ needs.createNewVersion.outputs.NEW_VERSION }} | |
| - name: Find open StagingDeployCash | |
| id: getStagingDeployCash | |
| run: echo "STAGING_DEPLOY_CASH=$(gh issue list --label StagingDeployCash --json number --jq '.[0].number')" >> "$GITHUB_OUTPUT" | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| - if: ${{ failure() }} | |
| uses: Expensify/App/.github/actions/composite/announceFailedWorkflowInSlack@main | |
| with: | |
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} | |
| # Check if actor is member of Expensify organization by looking for Expensify/expensify team | |
| isExpensifyEmployee: | |
| runs-on: ubuntu-latest | |
| outputs: | |
| IS_EXPENSIFY_EMPLOYEE: ${{ fromJSON(steps.checkAuthor.outputs.IS_EXPENSIFY_EMPLOYEE) }} | |
| steps: | |
| - name: Get merged pull request | |
| id: getMergedPullRequest | |
| uses: roryabraham/action-get-merged-pull-request@7a7a194f6ff8f3eef58c822083695a97314ebec1 | |
| with: | |
| github_token: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Check whether the PR author is member of Expensify/expensify team | |
| id: checkAuthor | |
| run: | | |
| if gh api /orgs/Expensify/teams/expensify-expensify/memberships/${{ steps.getMergedPullRequest.outputs.author }} --silent; then | |
| echo "IS_EXPENSIFY_EMPLOYEE=true" >> "$GITHUB_OUTPUT" | |
| else | |
| echo "IS_EXPENSIFY_EMPLOYEE=false" >> "$GITHUB_OUTPUT" | |
| fi | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| newContributorWelcomeMessage: | |
| runs-on: ubuntu-latest | |
| needs: isExpensifyEmployee | |
| if: ${{ github.actor != 'OSBotify' && !fromJSON(needs.isExpensifyEmployee.outputs.IS_EXPENSIFY_EMPLOYEE) }} | |
| steps: | |
| # Version: 2.3.4 | |
| - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 | |
| with: | |
| token: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| - name: Get merged pull request | |
| id: getMergedPullRequest | |
| # TODO: Point back action actions-ecosystem after https://github.com/actions-ecosystem/action-get-merged-pull-request/pull/223 is merged | |
| uses: roryabraham/action-get-merged-pull-request@7a7a194f6ff8f3eef58c822083695a97314ebec1 | |
| with: | |
| github_token: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Get PR count for ${{ steps.getMergedPullRequest.outputs.author }} | |
| run: echo "PR_COUNT=$(gh pr list --author ${{ steps.getMergedPullRequest.outputs.author }} --state any | grep -c '')" >> "$GITHUB_ENV" | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Comment on ${{ steps.getMergedPullRequest.outputs.author }}\'s first pull request! | |
| if: ${{ fromJSON(env.PR_COUNT) == 1 }} | |
| uses: actions-ecosystem/action-create-comment@cd098164398331c50e7dfdd0dfa1b564a1873fac | |
| with: | |
| github_token: ${{ secrets.OS_BOTIFY_TOKEN }} | |
| number: ${{ steps.getMergedPullRequest.outputs.number }} | |
| body: | | |
| @${{ steps.getMergedPullRequest.outputs.author }}, Great job getting your first Expensify/App pull request over the finish line! :tada: | |
| I know there's a lot of information in our [contributing guidelines](https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md), so here are some points to take note of :memo:: | |
| 1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time. | |
| 2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression. | |
| 3. Once your PR is deployed to _production_, we start a 7-day timer :alarm_clock:. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. :moneybag: | |
| So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! :blush: | |
| e2ePerformanceTests: | |
| needs: [chooseDeployActions] | |
| if: ${{ needs.chooseDeployActions.outputs.SHOULD_DEPLOY }} | |
| uses: Expensify/App/.github/workflows/e2ePerformanceTests.yml@main | |
| secrets: inherit | |
| with: | |
| PR_NUMBER: ${{ needs.chooseDeployActions.outputs.MERGED_PR }} |