Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataProcessor and InvertibleDataProcessor should be abstract #12

Open
kostaleonard opened this issue Dec 15, 2021 · 0 comments
Open

DataProcessor and InvertibleDataProcessor should be abstract #12

kostaleonard opened this issue Dec 15, 2021 · 0 comments
Assignees
@kostaleonard
Labels
enhancement New feature or request
Milestone
Second release

Comments

@kostaleonard
Copy link
Owner

kostaleonard commented Dec 15, 2021 •
edited
Loading

DataProcessor and InvertibleDataProcessor should be (and were) abstract classes; however, as a workaround for uqfoundation/dill#332 that prevented the serialization of objects inheriting from ABC, we made these classes concrete as suggested by uqfoundation/dill#332 (comment).

We want to add ABC inheritance back, but are waiting on uqfoundation/dill#427
@kostaleonard kostaleonard self-assigned this Dec 15, 2021
@kostaleonard kostaleonard added the enhancement New feature or request label Dec 15, 2021
@kostaleonard kostaleonard added this to the Second release milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostaleonard kostaleonard

Labels
enhancement New feature or request
Projects
None yet
Milestone
Second release
Development

No branches or pull requests
1 participant
@kostaleonard