-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 332 abc data #427
Issue 332 abc data #427
Conversation
you may want to check against any of these tests that are relevant: https://github.com/cloudpipe/cloudpickle/blob/343da119685f622da2d1658ef7b3e2516a01817f/tests/cloudpickle_test.py#L1170 |
8730f98
to
af11bbe
Compare
Can you give a short summary of what you feel is done and what is left to do? I'm heading toward a release, and trying to get some nagging issues/PRs tied up. I'll help with this if possible. |
3ba68e0
to
17085c1
Compare
17085c1
to
4cc7567
Compare
@mmckerns Status update
I don't think anything that previously worked would be broken by these changes, but I have not confirmed that ABC classes failed to pickle in python <= 3.6 |
@mmckerns @emfdavid Take a look at https://github.com/anivegesana/dill/tree/issue_332_abc_data and see if it is going in the direction that you want it. |
@anivegesana: Yeah, this is a good direction. |
@emfdavid Bump |
@anivegesana: feel free to assume the answer is yes, as opposed to waiting. |
Sorry for the delay - things have been a bit hectic for the start of the
year (sporadic child care with high covid rates in RI).
Please move forward - I will try to follow up tonight. Thank you for taking
up this issue!
…On Wed, Jan 19, 2022 at 11:16 AM Mike McKerns ***@***.***> wrote:
@anivegesana <https://github.com/anivegesana>: feel free to assume the
answer is yes, as opposed to waiting.
—
Reply to this email directly, view it on GitHub
<#427 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUDN2WZIW4LSVMLD4WK6VTDUW3PVXANCNFSM5DDA3FXA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Very cool @anivegesana - 2ce1c9e looks really good. |
…een lost in rebase.
Resolves #332
Register ABCMeta to use StockPickler. If workable, this is preferable to the cloudpickle solution that depends heavily on the internals of the ABC implementation.
This will remain broken on some versions of Python 3.7 that did not support pickling the new c implementation of ABC.
Issues: