【WIP】FCMトークンの登録 #180
Merged
【WIP】FCMトークンの登録 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsukamoto1783
commented
Sep 4, 2023
Comment on lines
84
to
100
|
|
||
| /// [FcmTokenRepository] のインスタンス。 | ||
| final _fcmTokenRepository = FcmTokenRepository(); | ||
| final _token = await ref.read(getFcmTokenProvider).call(); | ||
| final _userId = ref.read(userIdProvider); | ||
|
|
||
| final _deviceInfo = await getDeviceInfo(); | ||
|
|
||
| if (_token == null || _userId == null) { | ||
| return; | ||
| } | ||
|
|
||
| await _fcmTokenRepository.setUserFcmToken( | ||
| userId: _userId, | ||
| token: _token, | ||
| deviceInfo: _deviceInfo, | ||
| ); |
There was a problem hiding this comment.
こんな感じでやりたい事あってますでしょうか？？
There was a problem hiding this comment.
内容はあっています！が、他の書き込み処理を参考にサービスクラスをつくってそこで set の処理を書いてみてください！！（UI は Repository に直接依存させない、Repository とやりとりするのはモデルであるべき）
Comment on lines
40
to
66
| // TODO: パッケージ依存なのでcommonではない？ | ||
| Future<String> getDeviceInfo() async { | ||
| final _deviceInfoPlugin = DeviceInfoPlugin(); | ||
| late final String _os; | ||
| late final String _osVersion; | ||
| late final String _device; | ||
|
|
||
| if (Platform.isAndroid) { | ||
| final _androidInfo = await _deviceInfoPlugin.androidInfo; | ||
| _os = 'Android'; | ||
| _osVersion = _androidInfo.version.release; | ||
| _device = _androidInfo.device; | ||
| } else if (Platform.isIOS) { | ||
| final _iosInfo = await _deviceInfoPlugin.iosInfo; | ||
| _os = 'iOS'; | ||
| _osVersion = _iosInfo.systemVersion; | ||
| _device = _iosInfo.utsname.machine; | ||
| } else { | ||
| _os = ''; | ||
| _osVersion = ''; | ||
| _device = ''; | ||
| } | ||
|
|
||
| final _deviceInfo = 'os: $_os, osVersion: $_osVersion, device: $_device'; | ||
| return _deviceInfo; | ||
| } | ||
|
|
There was a problem hiding this comment.
こんな感じでやりたい事あってますでしょうか？？
There was a problem hiding this comment.
あっていると思います！
else は考えなくていい気もするので throw UnimplementedError とかでも良いかもしれません！
また、late final みたいなことは特にせずに単にそれぞれの if 句 else if 句の中で return した方が読みやすいようにも感じます！
Comment on lines
6
to
19
| /// 指定した [userId], [token]、[deviceInfo]をもとに ユーザーのFCMトークン情報を作成する。 | ||
| Future<void> setUserFcmToken({ | ||
| required String userId, | ||
| required String token, | ||
| required String deviceInfo, | ||
| }) => | ||
| _query.set( | ||
| userFcmTokenId: token, | ||
| createUserFcmToken: CreateUserFcmToken( | ||
| userId: userId, | ||
| token: token, | ||
| deviceInfo: deviceInfo, | ||
| ), | ||
| ); |
Comment on lines
84
to
90
| /// 指定した [UserFcmToken] を取得する [FutureProvider]. | ||
| final fcmTokenFutureProvider = FutureProvider.family | ||
| .autoDispose<ReadUserFcmToken?, String>((ref, userFcmTokenId) async { | ||
| return ref | ||
| .watch(fcmTokenRepositoryProvider) | ||
| .fetchUserFcmToken(userFcmTokenId: userFcmTokenId); | ||
| }); |
There was a problem hiding this comment.
サンプル実装なので良いですが、他を参考に
- View と Controller:
fcm_token/ui/fcm_token.dart - Model:
fcm_token/fcm_token.dart
に書くべきだと思います！
| return; | ||
| } | ||
|
|
||
| await _fcmTokenRepository.setUserFcmToken( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
close #49
説明
UI
その他
fcmToken確認用の開発ページは、あまりイケてるコードではないですが、確認用なのでいいかなと。（いい感じにしようとしてあまりうまくいかなかった。。）
→もし流石にもうちょっと綺麗にしたいとかあればおっしゃってください🙇
チェックリスト