Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'center' alignments in ToastManager #374

Closed
bploeckelman opened this issue Dec 9, 2022 · 0 comments
Closed

Support 'center' alignments in ToastManager #374

bploeckelman opened this issue Dec 9, 2022 · 0 comments
Labels
enhancement ui

Comments

@bploeckelman
Copy link
Contributor

bploeckelman commented Dec 9, 2022 •
edited
Loading

Looks like bottom, top, left, right and their combinations are the only supported Toast position alignment values. Other UI widgets are often stuffed into screen corners and end up fighting with Toast visibility so it would be helpful to also support center, though possibly just for the bottom and top edges.

At the very least, changing ToastManager.updateToastsPositions() to protected visibility would allow end-users to customize positioning behavior themselves just by extending ToastManager and overriding the method rather than having to copy the whole thing into a customization class in order to change that behavior.
czyzby added a commit that referenced this issue Dec 9, 2022
@czyzby
Make ToastManager.updateToastsPositions protected (#374)
1625676
@czyzby czyzby mentioned this issue Dec 9, 2022
Closed
czyzby added a commit that referenced this issue Dec 9, 2022
@czyzby
ToastManager.updateToastsPositions documentation #374
cd03fc9
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Make ToastManager.updateToastsPositions and member variables protected (
fd84510 
kotcrab#374)
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Add support for 'center' alignments in ToastManager (kotcrab#374)
6cb8ef9
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Update TestToasts to include top/bottom center alignment options (kot…
d091574 
…crab#374)
bploeckelman added a commit to bploeckelman/vis-ui that referenced this issue Dec 10, 2022
@bploeckelman
Change log updated with ToastManager changes related to (kotcrab#374)
e951530
@bploeckelman bploeckelman mentioned this issue Dec 10, 2022
Merged
czyzby pushed a commit that referenced this issue Dec 10, 2022
@bploeckelman
Toast manager center alignment support (#374)
4bf70db 
* Make ToastManager.updateToastsPositions and member variables protected (#374)

* Add support for 'center' alignments in ToastManager (#374)

* Update TestToasts to include top/bottom center alignment options (#374)

* Change log updated with ToastManager changes related to (#374)
@czyzby czyzby closed this as completed Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bploeckelman @czyzby