Fixed a binary compatibility error when using a higher version of KotlinModule #527
Conversation
| @@ -31,7 +31,7 @@ import java.sql.Types | |||
| */ | |||
| public val sharedObjectMapper: ObjectMapper = ObjectMapper() | |||
| .registerModule(KtormModule()) | |||
| .registerModule(KotlinModule()) | |||
| .registerModule(kotlinModule()) | |||
There was a problem hiding this comment.
Shouldn't this be the following?
.registerModule(KotlinModule.Builder().build())
There was a problem hiding this comment.
kotlinModule() is a short hand that does the same.
There was a problem hiding this comment.
@arnodenuijl , could you check the answer from @k163377 and review again?
There was a problem hiding this comment.
Hi. Sadly it's not mine to merge. I just commented because I had the same issue and didn't understand the fix. But it's not my repo and I don't have any rights on it.
|
Hi @arnodenuijl |
|
Hi @vincentlauvlwj can you have a look please? |
|
@vincentlauvlwj |
Yes, of course. So sorry for the late response. |
|
Would love to see this PR merged and released; many projects are moving on to higher versions of jackson over time, including spring boot requiring it now in 3.3. |
|
It would be great to get this PR merged, we are stuck with old versions ktor and other stuff because of the breaking change in jackson. |
|
Wanted to try to ping @vincentlauvlwj again to see if we can get a merge and release for this, to unblock jackson upgrades? |
|
Merged into the dev branch, will release in next weeks. |
Since
2.11,KotlinModulerecommends initialization withBuilder.If initialization is done by primary constructor calls with default arguments, subsequent option additions will cause problems such as #526.
In local verification, this resolved #526.