Skip to content

Commit

Permalink
issues and improvements (#5)
Browse files Browse the repository at this point in the history
release (0.1.1) issues and improvements
  • Loading branch information
kotlitecture committed Jun 1, 2024
1 parent 7fd0661 commit d450f4b
Show file tree
Hide file tree
Showing 15 changed files with 74 additions and 50 deletions.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
2 changes: 1 addition & 1 deletion processor/build.gradle
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apply from: "${project.rootDir}/gradle/kotlin/processor.gradle"

group = 'com.kotlitecture.kotli'
version = '0.1.0'
version = '0.1.1'
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ object AndroidPlatformProcessor : PlatformProcessor() {
state.onApplyRules(
VersionCatalogRules(
RemoveMarkedLine("agp"),
RemoveMarkedLine("android-jvmTarget"),
RemoveMarkedLine("android-compileSdk"),
RemoveMarkedLine("android-minSdk"),
RemoveMarkedLine("android-targetSdk"),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Run

https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-multiplatform-create-first-app.html#run-your-application-on-android
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Run

https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-multiplatform-create-first-app.html#run-your-application-on-ios
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Run

```
./gradlew jsBrowserRun
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Run

```
./gradlew run
```
12 changes: 6 additions & 6 deletions template/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
plugins {
alias(libs.plugins.androidApplication) apply false
alias(libs.plugins.androidLibrary) apply false
alias(libs.plugins.composeCompiler) apply false
alias(libs.plugins.composeMultiplatform) apply false
alias(libs.plugins.kotlinMultiplatform) apply false
alias(libs.plugins.kotlinxSerialization) apply false
alias(libs.plugins.android.application) apply false
alias(libs.plugins.android.library) apply false
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.compose.multiplatform) apply false
alias(libs.plugins.kotlin.multiplatform) apply false
alias(libs.plugins.kotlinx.serialization) apply false
}
3 changes: 3 additions & 0 deletions template/composeApp/assemble/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

-dontwarn kotlinx.**
-dontwarn org.slf4j.**
-dontwarn org.slf4j.impl.StaticLoggerBinder
-dontwarn java.lang.management.ManagementFactory
-dontwarn java.lang.management.RuntimeMXBean

-keep,includedescriptorclasses class kotli.app.**$$serializer { *; }
-keepclassmembers class kotli.app.** {
Expand Down
21 changes: 12 additions & 9 deletions template/composeApp/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import org.jetbrains.compose.desktop.application.dsl.TargetFormat // {platform.jvm}
import org.jetbrains.kotlin.gradle.targets.js.webpack.KotlinWebpackConfig // {platform.js}
plugins {
alias(libs.plugins.kotlinMultiplatform)
alias(libs.plugins.kotlinxSerialization)
alias(libs.plugins.composeCompiler)
alias(libs.plugins.composeMultiplatform)
alias(libs.plugins.androidApplication) // {platform.android}
alias(libs.plugins.kotlin.multiplatform)
alias(libs.plugins.kotlinx.serialization)
alias(libs.plugins.compose.compiler)
alias(libs.plugins.compose.multiplatform)
alias(libs.plugins.android.application) // {platform.android}
alias(libs.plugins.skie) // {platform.ios}
}

Expand All @@ -14,7 +14,7 @@ kotlin {
androidTarget {
compilations.all {
kotlinOptions {
jvmTarget = "11"
jvmTarget = libs.versions.android.jvmTarget.get()
}
}
}
Expand Down Expand Up @@ -104,13 +104,16 @@ android {
}
}
buildTypes {
getByName("release") {
named("release") {
isDebuggable = false
isMinifyEnabled = true
isShrinkResources = true
proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "assemble/proguard-rules.pro")
}
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility(libs.versions.android.jvmTarget.get())
targetCompatibility(libs.versions.android.jvmTarget.get())
}
dependencies {
debugImplementation(libs.compose.ui.tooling)
Expand Down
23 changes: 12 additions & 11 deletions template/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[versions]
agp = "8.2.2"
android-compileSdk = "34"
android-jvmTarget = "11"
android-minSdk = "24"
android-targetSdk = "34"
androidx-activity = "1.9.0"
Expand All @@ -15,10 +16,10 @@ compose-multiplatform = "1.6.10"
junit = "4.13.2"
koin = "3.6.0-Beta4"
kotlin = "2.0.0"
kotlinx-coroutines = "1.8.0"
kotlinx-coroutines = "1.9.0-RC"
kotlinx-datetime = "0.6.0"
kotlinx-serialization-json = "1.6.3"
ktor = "2.3.10"
ktor = "2.3.11"
multiplatform-settings = "1.1.1"
napier = "2.7.1"
skie = "0.8.0"
Expand Down Expand Up @@ -58,15 +59,15 @@ multiplatform-settings-test = { module = "com.russhwolf:multiplatform-settings-t
napier = { module = "io.github.aakira:napier", version.ref = "napier" }
touchlab-kermit = { module = "co.touchlab:kermit", version.ref = "touchlab-kermit" }

[plugins]
androidApplication = { id = "com.android.application", version.ref = "agp" }
androidLibrary = { id = "com.android.library", version.ref = "agp" }
composeCompiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
composeMultiplatform = { id = "org.jetbrains.compose", version.ref = "compose-multiplatform" }
kotlinMultiplatform = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin" }
kotlinxSerialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
skie = { id = "co.touchlab.skie", version.ref = "skie" }

[bundles]
ktor-common = ["ktor-client-core", "ktor-client-logging", "ktor-client-serialization", "ktor-client-contentNegotiation", "ktor-client-websockets"]

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
android-library = { id = "com.android.library", version.ref = "agp" }
compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
compose-multiplatform = { id = "org.jetbrains.compose", version.ref = "compose-multiplatform" }
kotlin-multiplatform = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin" }
kotlinx-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
skie = { id = "co.touchlab.skie", version.ref = "skie" }

2 changes: 1 addition & 1 deletion template/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
16 changes: 8 additions & 8 deletions template/shared/core/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
plugins {
alias(libs.plugins.kotlinMultiplatform)
alias(libs.plugins.kotlinxSerialization)
alias(libs.plugins.composeCompiler)
alias(libs.plugins.composeMultiplatform)
alias(libs.plugins.androidLibrary) // {platform.android}
alias(libs.plugins.kotlin.multiplatform)
alias(libs.plugins.kotlinx.serialization)
alias(libs.plugins.compose.compiler)
alias(libs.plugins.compose.multiplatform)
alias(libs.plugins.android.library) // {platform.android}
}

kotlin {
// {platform.android.target}
androidTarget {
compilations.all {
kotlinOptions {
jvmTarget = "11"
jvmTarget = libs.versions.android.jvmTarget.get()
}
}
}
Expand Down Expand Up @@ -64,8 +64,8 @@ android {
namespace = "shared.core"
compileSdk = libs.versions.android.compileSdk.get().toInt()
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility(libs.versions.android.jvmTarget.get())
targetCompatibility(libs.versions.android.jvmTarget.get())
}
defaultConfig {
minSdk = libs.versions.android.minSdk.get().toInt()
Expand Down
12 changes: 6 additions & 6 deletions template/shared/data/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
plugins {
alias(libs.plugins.kotlinMultiplatform)
alias(libs.plugins.kotlinxSerialization)
alias(libs.plugins.androidLibrary) // {platform.android}
alias(libs.plugins.kotlin.multiplatform)
alias(libs.plugins.kotlinx.serialization)
alias(libs.plugins.android.library) // {platform.android}
}

kotlin {
// {platform.android.target}
androidTarget {
compilations.all {
kotlinOptions {
jvmTarget = "11"
jvmTarget = libs.versions.android.jvmTarget.get()
}
}
}
Expand Down Expand Up @@ -71,8 +71,8 @@ android {
namespace = "shared.data"
compileSdk = libs.versions.android.compileSdk.get().toInt()
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility(libs.versions.android.jvmTarget.get())
targetCompatibility(libs.versions.android.jvmTarget.get())
}
defaultConfig {
minSdk = libs.versions.android.minSdk.get().toInt()
Expand Down
14 changes: 7 additions & 7 deletions template/shared/design/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
plugins {
alias(libs.plugins.kotlinMultiplatform)
alias(libs.plugins.composeCompiler)
alias(libs.plugins.composeMultiplatform)
alias(libs.plugins.androidLibrary) // {platform.android}
alias(libs.plugins.kotlin.multiplatform)
alias(libs.plugins.compose.compiler)
alias(libs.plugins.compose.multiplatform)
alias(libs.plugins.android.library) // {platform.android}
}

kotlin {
// {platform.android.target}
androidTarget {
compilations.all {
kotlinOptions {
jvmTarget = "11"
jvmTarget = libs.versions.android.jvmTarget.get()
}
}
}
Expand Down Expand Up @@ -52,8 +52,8 @@ android {
namespace = "shared.design"
compileSdk = libs.versions.android.compileSdk.get().toInt()
compileOptions {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
sourceCompatibility(libs.versions.android.jvmTarget.get())
targetCompatibility(libs.versions.android.jvmTarget.get())
}
defaultConfig {
minSdk = libs.versions.android.minSdk.get().toInt()
Expand Down

0 comments on commit d450f4b

Please sign in to comment.