Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oop tiny js world #196

Closed
wants to merge 1 commit into from
Closed

oop tiny js world #196

wants to merge 1 commit into from

Conversation

DaniaB24
Copy link
Contributor

@DaniaB24 DaniaB24 commented Jul 20, 2022

Replace task name and links as appropriate and remove this line.

oop tiny js world

Demo |
Code base

The code is submitted in its own sub-directory and in a dedicated feature branch.
Please, review.

@OleksiyRudenko OleksiyRudenko self-requested a review July 24, 2022 10:37
Copy link
Member

@OleksiyRudenko OleksiyRudenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the code against the following requirements, fix as appropriate and confirm compliance.

  • Code is DRY, which means that whenever you see
    a pattern in your code those should be eliminated as much as possible. Examples:
    • print(dog); print(cat); etc ... should be refactored employing Array.forEach as the least
    • `${obj.legs}; ${obj.name}; etc...` (yes, strings are also code) must be refactored employing appropriate Array methods
  • Properties used to form an object presentation string must be explicitly listed/specified
  • Object methods like keys, values, entries shouldn't be used as these do not guarantee any particular order of keys/values
  • Use statement termination semicolons consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task-TJSW Task: Building a Tiny JS World
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants