Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory pair game #198

Merged
merged 7 commits into from
Sep 28, 2022
Merged

memory pair game #198

merged 7 commits into from
Sep 28, 2022

Conversation

DaniaB24
Copy link
Contributor

@DaniaB24 DaniaB24 commented Jul 20, 2022 •
edited
Loading

memory pair game

Demo |
Code base

The code is submitted in its own sub-directory and in a dedicated feature branch.
Please, review.

@OleksiyRudenko OleksiyRudenko added the task-MPG Task: Memory Pair Game label Jul 24, 2022
@OleksiyRudenko
Copy link
Member

Please keep only files required for the code review (i.e. codebase part that was authored by you).
See section B123 of submission guidelines. This helps reviewers jump straight to their job and makes their life easier.

@DaniaB24 DaniaB24 mentioned this pull request Aug 16, 2022
Open
4 tasks
@DaniaB24
Copy link
Contributor Author

Please keep only files required for the code review (i.e. codebase part that was authored by you). See section B123 of submission guidelines. This helps reviewers jump straight to their job and makes their life easier.

Hi^ sorry, okey I will remove)

@OleksiyRudenko
Copy link
Member

Quite unexpected UX, esp. closer to the end of game.
Also doesn't reshuffle cards for the next game.
Record_2022_08_17_14_37_34_731-xs

@DaniaB24
Copy link
Contributor Author

Quite unexpected UX, esp. closer to the end of game.
Also doesn't reshuffle cards for the next game.
Record_2022_08_17_14_37_34_731-xs

okey, I will do it^ thanks for the review <3

@OleksiyRudenko
Copy link
Member

OleksiyRudenko commented Aug 18, 2022 •
edited
Loading

Looks visually nice.
How about posting a link in the students' chat and collecting user feedback?

@DaniaB24
Copy link
Contributor Author

Looks visually nice.
How about posting a link in the students' chat and collecting user feedback?

okey, thanks a lot

@OleksiyRudenko
Copy link
Member

This PR contains code from different tasks. Need to fix this

@DaniaB24
Copy link
Contributor Author

This PR contains code from different tasks. Need to fix this

yeah... I did it

@OleksiyRudenko
Copy link
Member

OleksiyRudenko commented Aug 26, 2022 •
edited
Loading

Which files do we review?

image

@DaniaB24
Copy link
Contributor Author

Which files do we review?

image

@OleksiyRudenko re-review pls:) i think now everything is clear^

@DaniaB24
Copy link
Contributor Author

DaniaB24 commented Sep 4, 2022

@OleksiyRudenko

@DaniaB24
Copy link
Contributor Author

DaniaB24 commented Sep 8, 2022

@OleksiyRudenko re-review please) thank you a lot

@DaniaB24
Copy link
Contributor Author

@OleksiyRudenko

lysenko-sergey-developer
lysenko-sergey-developer suggested changes Sep 15, 2022
View reviewed changes
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
submissions/DaniaB24/memory-pair-game/js/app.js Outdated Show resolved Hide resolved
@lysenko-sergey-developer
Copy link

@DaniaB24 Good work!👍

@DaniaB24
Copy link
Contributor Author

@DaniaB24 Good work!👍

thank you a lot for review 🤝🤗 I will do it🫡

@DaniaB24
Copy link
Contributor Author

@lysenko-sergey-developer @OleksiyRudenko friendly reminder

@OleksiyRudenko OleksiyRudenko merged commit 7314937 into kottans:master Sep 28, 2022
@DaniaB24
Copy link
Contributor Author

@OleksiyRudenko @lysenko-sergey-developer thanks a lot<333

@OleksiyRudenko
Copy link
Member

@DaniaB24 looks like you are missing only submission for OOP Exercise to have the full house of tasks.

@DaniaB24
Copy link
Contributor Author

@DaniaB24 looks like you are missing only submission for OOP Exercise to have the full house of tasks.

kottans/frontend-2022-homeworks#172
it seems to be here

@OleksiyRudenko
Copy link
Member

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

@DaniaB24
Copy link
Contributor Author

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

image
but there is a code for oop 🤦‍♂️

@DaniaB24
Copy link
Contributor Author

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

kottans/frontend-2022-homeworks#172 it seems to be here

That PR covers Building a Tiny JS World

image but there is a code for oop 🤦‍♂️

sorry, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysenko-sergey-developer lysenko-sergey-developer lysenko-sergey-developer requested changes

Assignees
No one assigned
Labels
task-MPG Task: Memory Pair Game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniaB24 @OleksiyRudenko @lysenko-sergey-developer