Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup #110

Merged
merged 13 commits into from
Aug 19, 2022
Merged

popup #110

merged 13 commits into from
Aug 19, 2022

Conversation

vovan-zt
Copy link
Contributor

@vovan-zt vovan-zt commented Aug 10, 2022

HTML & CSS Practice

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/style.css Outdated Show resolved Hide resolved
submissions/vovan-zt/popup/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 16, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last issue left

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last issue)

</div>
</li>
<li class="navigation__item">
<a href="#"><img class="navigation__image" src="icons/bell.png" alt="bell3"></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You remove alt value for icons in the popup what about these icons?)

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit b25f396 into kottans:main Aug 19, 2022
@vovan-zt vovan-zt deleted the vovan-popup branch August 20, 2022 08:21
@vovan-zt vovan-zt restored the vovan-popup branch August 20, 2022 18:49
@vovan-zt vovan-zt deleted the vovan-popup branch August 21, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants