Tiny-world #194
Merged
Tiny-world #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiyRudenko
requested changes
Aug 16, 2022
There was a problem hiding this comment.
@MarharytaBoichenko well done!
A couple of improvements and we are done.
| ]; | ||
|
|
||
| inhabitants.forEach((item) => { | ||
| console.log(item); |
There was a problem hiding this comment.
Please remove debugging statements from code here and before submitting other tasks.
Comment on lines
10
to
19
| species: "man", | ||
| gender: "male", | ||
| hands: 2, | ||
| legs: 2, | ||
| saying: "hello", | ||
| friends: ["Bob", "Ann", "Nick"], | ||
| }; | ||
| const woman = { | ||
| name: "Ann", | ||
| species: "woman", |
There was a problem hiding this comment.
Men and women belong to the same species.
Comment on lines
64
to
66
| const allInfoInItem = allProperties.map((prop) => | ||
| item[prop] ? item[prop] : `no ${prop}` | ||
| ); |
There was a problem hiding this comment.
You don't really want to spend resource on creation of locally scoped method at every loop iteration. Think of 100k iterations.
OleksiyRudenko
approved these changes
Aug 17, 2022
| inhabitants.forEach((item) => { | ||
| print( | ||
| allProperties | ||
| .map((prop) => (item[prop] ? item[prop] : `no ${prop}`)) |
There was a problem hiding this comment.
You don't really need so many parentheses in arrow functions, they do not really help to identify boundaries of code components, especially in one liners.
.map((prop) => (item[prop] ? item[prop] : `no ${prop}`))
.map(prop => item[prop] ? item[prop] : `no ${prop}`)
There was a problem hiding this comment.
exactly) thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Tiny JS World
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.