Frogger-game

[zhenyakornilov]

Object-Oriented JS - Frogger-game

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

[zhenyakornilov]

Covered some common mistakes:

1. Class Enemy do not refer to global player variable, player passed to Enemy constructor instead.
2. Enemy update() method do not call checkOverlap() method inside. Moved checkOverlap() method to updateEntities function in engine.js instead.

[OleksiyRudenko]

2. Enemy update() method do not call checkOverlap() method inside. Moved checkOverlap() method to updateEntities function in engine.js instead.

Please bring it back to the app.js for the sake of code review scope. It can perfectly be a part of Enemy class (as it is specific to Enemy behaviour), just needs to be a method on its own.

[OleksiyRudenko]

@zhenyakornilov very well coded!

Apart of bringing collision checking function back as mentioned above, let's add more semantics to the constants so that peer developers were able to read what every number means and implement changes quickly when needed.

[OleksiyRudenko]

WHat is 10 here and across the codebase? I guess -10 is the same but just negative. If true then having OFFSET = 10 and referring to it as OFFSET and -OFFSET would be fine.
Of course OFFSET word doesn't explain it application, so invent a better name.

[OleksiyRudenko]

What is 60?

[zhenyakornilov]

Made some changes

[OleksiyRudenko]

@zhenyakornilov please go through your code and extrapolate previous comments re magic numbers to all other similar situations in your code.
Do not expect a reviewer to "red pen" every single tiny bug in the code. Own it truly.

[zhenyakornilov]

It seems to be a bit better now.

[OleksiyRudenko]

@zhenyakornilov a really good job!

Hint on naming in graphic environments:
In regular structures like matrices, game fields (which are also matrices) elements' coordinates are defined by row (or column), matrix row height (or matrix column width), and offset.
So, for e.g. y = verticalOffset + row * rowHeight. Items to place into the matrix may have their own individual offsets (like in this game where visual part has offsets against its pixel representation).
So having defined offsets, widths and heights it is possible to calculate any coordinates based on row and column index.