Html css popup #206
Merged
Html css popup #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Congratulations with your PR! 😎😎😎 Please, be sure you haven't followed common mistakes. Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒 |
HannaSyn
requested changes
Aug 23, 2022
| <ul class="popup__menu__main"> | ||
| <li class="popup__menu__item"> | ||
| <a href="#Calendar"> | ||
| <img src="images/kottans-calendar.png" alt="Calendar" class="popup__icons"> |
There was a problem hiding this comment.
For icons it's better set an empty alt attribute, read more here
| <nav class="nav__menu"> | ||
| <ul class="ul__items"> | ||
| <li> | ||
| <a href="#Mail" class="main__nav-buttons mail"><span |
There was a problem hiding this comment.
Please, read more about BEM
I don't see class name of block main__nav
|
Thanks for your review! I made the changes and it should be better now. |
SphericalCat
pushed a commit
to SphericalCat/frontend-2022-homeworks
that referenced
this pull request
Aug 30, 2022
* added files for HTML-CSS-POPUP task * Added empty row at the end * created responsive design * fixed # of colors, removed value in alt, added BEM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML-CSS-Popup
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.