taskPopup #209
taskPopup #209
Conversation
|
Thank you for contributing to this repo! ❤️️ This PR intro message is not completed. Please edit it following the instructions therein and mark the checkbox below when done.
How to start editing the top comment:
Sincerely yours, |
|
Corrected |
|
Hey! Congratulations with your PR! 😎😎😎 Please, be sure you haven't followed common mistakes. Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒 |
|
verified |
| <body> | ||
| <header class="header"> | ||
| <!-- пусть это будет лого) --> | ||
| <img src="./img-check/favicon.png" alt="" class="icon-nav-link check-icon_s logo" tabindex="1" > |
There was a problem hiding this comment.
The logo should be a link and leads users to the home page.
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href="./style.css"> | ||
| <title>Document</title> |
There was a problem hiding this comment.
Add propper page title
| <nav> | ||
| <ul class="nav-menu"> | ||
| <li class="list-nav"><a href="#" class="link-nav">Mail</a> </li> | ||
| <li class="list-nav"><a href="#" class="link-nav" >Images</a></li> | ||
| <li class="popup-menu"> |
There was a problem hiding this comment.
Fix code indentation, use Prettier for it.
| <!-- контейнер для иконок-ссылок --> | ||
| <ul class="nav-item"> | ||
| <li > | ||
| <a href="#" class="check-item link" tabindex="0" ><img src="./img-check/calendar.png" alt="calendar" class="check-icons " > |
There was a problem hiding this comment.
tabindex="0" on interactive element makes no sense.
| <a href="#" class="check-item link" tabindex="0" ><img src="./img-check/calendar.png" alt="calendar" class="check-icons " > | ||
| <p>Calendar</p></a></li> | ||
| <li> | ||
| <a href="#" class="check-item link"><img src="./img-check/blogs.png" alt="blogs" class="check-icons" > |
There was a problem hiding this comment.
Read how and when to populate alt attribute value Как правильно написать alt-текст
| </header> | ||
|
|
||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Add an empty line at the end of each file. Reason
| <!-- пусть это будет лого) --> | ||
| <img src="./img-check/favicon.png" alt="" class="icon-nav-link check-icon_s logo" tabindex="1" > | ||
| <!-- навигация хедера --> | ||
| <nav> |
| @@ -0,0 +1,102 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
By default your popup is open, it must be closed, also, fix the order of interactive elements.
|
This issue has been automatically marked as stale because there were no activity during last 14 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. А. Чому так? Б. Що робити, якщо в піарі нема оновлень, оскільки не зрозуміло, що треба зробити? В. А якщо я все зробив(ла) і це ментор не рев'юває мої зміни?
Г. Хіба недостатньо того, що я додав(ла) коміт із змінами? Традиційна пропозиція: задай питання по вищенаписаному в студентському чаті. |
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.