Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooli style popup #212

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Hooli style popup #212

merged 4 commits into from
Aug 31, 2022

Conversation

drewzag
Copy link
Contributor

@drewzag drewzag commented Aug 18, 2022

Hooli-style Popup

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@github-actions
Copy link

Hey!

Congratulations with your PR! 😎😎😎

Please, be sure you haven't followed common mistakes.

Also, be aware, that if you would silently ignore this recommendation, a mentor may think that you are still working on fixes. And your PR will not be reviewed. 😒

@A-Ostrovnyy A-Ostrovnyy self-assigned this Aug 27, 2022
Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Sorry for the late response.

submissions/drewzag/hooli-style-popup/index.html Outdated Show resolved Hide resolved
submissions/drewzag/hooli-style-popup/index.html Outdated Show resolved Hide resolved
submissions/drewzag/hooli-style-popup/style.css Outdated Show resolved Hide resolved
@drewzag
Copy link
Contributor Author

drewzag commented Aug 29, 2022

@A-Ostrovnyy Honestly, It was quite difficult, but I think I did it)

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

submissions/drewzag/hooli-style-popup/index.html Outdated Show resolved Hide resolved
@drewzag
Copy link
Contributor Author

drewzag commented Aug 30, 2022

@A-Ostrovnyy I hope, I did it wright this time)
Thank you for reviewing my code

Copy link
Collaborator

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@A-Ostrovnyy A-Ostrovnyy merged commit 277cff9 into kottans:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants