A Tiny JS World #220
A Tiny JS World #220
Conversation
There was a problem hiding this comment.
@SofiiaTrokhymchuk well done!
A couple of improvements and we're good to go.
| const friends = []; | ||
| if(inhabitant.friends === undefined){ | ||
| friends.push(0); | ||
| }else{ | ||
| friends.push(...inhabitant.friends); | ||
| } |
There was a problem hiding this comment.
- Can we employ ternary operator here?
friends.push(0): why not assign a value of[0]?friends.push(...inhabitant.friends):arr = [...sourceArr]is another (ES6) way to copy elements into a new array. But why do we need to have a copy at all?
There was a problem hiding this comment.
@SofiiaTrokhymchuk a good optimization step.
Let's make yet another one to have even less verbose code.
| let friends = []; | ||
| inhabitant.friends === undefined ? friends[0] = 0 : friends = inhabitant.friends; |
There was a problem hiding this comment.
- Proper use of Ternary operator
[0]is a legitimate assignable value.- These 2 statements can be a single statements.
There was a problem hiding this comment.
You mean, that I need to combine a declaration and initialisation of friends and ternary operator into a single statement?
| @@ -50,10 +50,9 @@ catWoman.legs = 2; | |||
| catWoman.hands = 2; | |||
|
|
|||
| function inhabitantToString(inhabitant){ | |||
| let friends = []; | |||
| inhabitant.friends === undefined ? friends[0] = 0 : friends = inhabitant.friends; | |||
| inhabitant.friends === undefined ? inhabitant.friends = [0] : inhabitant.friends = inhabitant.friends; | |||
There was a problem hiding this comment.
The intention is good. However, there two issues:
- You mutate original property value. Other fragments of project may want different interpretation of the situation when friends are not defined.
- That's exactly an antipattern (
condition ? targetVariable = x : targetVariable = y) for the ternary operator.
Please bring back interim friends variable and retry. Dedicate more time to the linked above article. You will use ternaries often, it is worth mastering.
There was a problem hiding this comment.
Sorry, I didn't pay my attention enough. 5 minutes and it will be fixed!
A Tiny JS World
Demo |
Code base
The code is submitted in a dedicated feature branch.
Only code files are submitted.
Please, review.